Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedded models parsing with key_name #262

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

art049
Copy link
Owner

@art049 art049 commented Sep 8, 2022

Fixes #260
Supersedes #261

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

🚀 Deployed on https://docs-preview-262--odmantic.netlify.app

@art049 art049 mentioned this pull request Sep 8, 2022
@art049 art049 changed the title Fix embedded model key name doc parsing Fix embedded models with key_name parsing Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #262 (be0e8b0) into master (91d015b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head be0e8b0 differs from pull request most recent head d958f8e. Consider uploading reports for the commit d958f8e to get more accurate results

@@            Coverage Diff            @@
##            master      #262   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4624      4679   +55     
  Branches       793       808   +15     
=========================================
+ Hits          4624      4679   +55     
Flag Coverage Δ
tests-3.10-4.4-standalone 94.07% <100.00%> (+0.07%) ⬆️
tests-3.10-5-standalone 94.07% <100.00%> (+0.07%) ⬆️
tests-3.10-6-standalone 94.07% <100.00%> (+0.07%) ⬆️
tests-3.7-4.4-standalone 92.33% <100.00%> (+0.09%) ⬆️
tests-3.7-5-standalone 92.33% <100.00%> (+0.09%) ⬆️
tests-3.7-6-standalone 92.33% <100.00%> (+0.09%) ⬆️
tests-3.8-4-replicaSet 99.01% <100.00%> (+0.01%) ⬆️
tests-3.8-4.2-sharded 93.20% <100.00%> (+0.08%) ⬆️
tests-3.8-4.4-standalone 94.07% <100.00%> (+0.07%) ⬆️
tests-3.8-5-standalone 94.07% <100.00%> (+0.07%) ⬆️
tests-3.8-6-standalone 94.07% <100.00%> (+0.07%) ⬆️
tests-3.9-4.4-standalone 93.99% <100.00%> (+0.07%) ⬆️
tests-3.9-5-standalone 93.99% <100.00%> (+0.07%) ⬆️
tests-3.9-6-standalone 93.99% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/model.py 100.00% <100.00%> (ø)
tests/integration/test_embedded_model.py 100.00% <100.00%> (ø)
tests/unit/test_model_definition.py 100.00% <100.00%> (ø)
tests/unit/test_model_logic.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

iXB3 and others added 2 commits September 9, 2022 00:48
Fix bug (issue #260): when using key_name in EmbeddedModel's fields, insertion work properly but resuming document fails
@art049 art049 force-pushed the fix-embedded-model-key-name-doc-parsing branch from 939644a to 7eff00b Compare September 8, 2022 22:48
@art049 art049 force-pushed the fix-embedded-model-key-name-doc-parsing branch from be0e8b0 to d958f8e Compare September 8, 2022 23:45
@art049 art049 changed the title Fix embedded models with key_name parsing Fix embedded models parsing with key_name Sep 8, 2022
@art049 art049 merged commit 38ff536 into master Sep 8, 2022
@art049 art049 deleted the fix-embedded-model-key-name-doc-parsing branch September 8, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

key_name in EmbeddedModel's field make document instantiation not working
2 participants