Skip to content

["Request"] Fix incorrect Sequence signatures  #2966

Closed
@nomisRev

Description

What version are you currently using?

1.x.x

What would you like to see?

There are a bunch of Sequence signatures that in their signature give the impression that they're lazy, but in reality they're terminal and consume the entire Sequence before returning.

From my short investigation it looks like these cannot be made lazy, but perhaps we can instead update their implementation for them to return List instead of Sequence.

  • crosswalk
  • crosswalkMap
  • crosswalkNull
  • separateEither
  • unalign
  • unzip

This might be possible to rewrite as a lazy version:

  • unweave (investigate if can be made lazy)

Activity

added
2.0.0Tickets / PRs belonging to Arrow 2.0
on Mar 7, 2023
self-assigned this
on Mar 21, 2023
serras

serras commented on Mar 24, 2023

@serras
Member

Implementations returning List have been added as part of #2993, and the incorrect ones marked for deprecation. We should remember to remove them in 2.0.

nomisRev

nomisRev commented on Apr 5, 2023

@nomisRev
MemberAuthor

This was taken care of by @gutiory and released in 1.2.0-RC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

2.0.0Tickets / PRs belonging to Arrow 2.0

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    ["Request"] Fix incorrect Sequence signatures · Issue #2966 · arrow-kt/arrow