Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor armbian-config into install as external package #7716

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Refactor armbian-config into install as external package #7716

merged 2 commits into from
Jan 20, 2025

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jan 18, 2025 •
edited
Loading

Description

Since this tool will have deeper integration with Armbian, we should probably drop possibility to remove the tool from the list.

  • this resolves problem of versioning. Not attached to the build FW anymore.
  • https://github.armbian.com/configng repository is always present
  • package can still be removed from the install list

Needs: #7719

How Has This Been Tested?

  • Generating image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik requested a review from rpardini January 18, 2025 10:22
@igorpecovnik igorpecovnik requested a review from a team as a code owner January 18, 2025 10:22
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Framework Framework components labels Jan 18, 2025
@igorpecovnik igorpecovnik added the 02 Milestone: First quarter release label Jan 18, 2025
@igorpecovnik igorpecovnik force-pushed the armbian-config branch 4 times, most recently from 1f0d857 to 3c56baa Compare January 19, 2025 20:48
@github-actions github-actions bot added size/large PR with 250 lines or more and removed size/medium PR with more then 50 and less then 250 lines labels Jan 19, 2025
@igorpecovnik
Refactor armbian-config into install as external package
c30e5db 
- https://github.armbian.com/configng repository is always present
- package can still be removed from the install list

Since this tool will have deeper integration with Armbian, we should probably drop possibility to remove the tool from the list.
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Jan 20, 2025
@igorpecovnik igorpecovnik merged commit 4e33412 into main Jan 20, 2025
10 checks passed
@igorpecovnik igorpecovnik deleted the armbian-config branch January 20, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpardini rpardini Awaiting requested review from rpardini

Assignees
No one assigned
Labels
02 Milestone: First quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@igorpecovnik