[executor] Allow retrying fail pods that haven't had any containers start #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tart Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
JamesMurkin
commented
Jan 16, 2025
| return | ||
| } | ||
|
|
||
| if pod.Status.Phase == v1.PodFailed { |
There was a problem hiding this comment.
The code in this if statement is largely the only new code in this file, the rest is just split out from job_event_reporter
d80tb7
reviewed
Jan 17, 2025
| podEventChecks := make([]podEventCheck, 0, len(checks)) | ||
|
|
||
| for _, check := range checks { | ||
| re, err := regexp.Compile(check.Regexp) |
There was a problem hiding this comment.
At some point it would be nice to see if we can get viper to marshall regexes and push stuff like this to config validation.
d80tb7
previously approved these changes
Jan 17, 2025
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com> # Conflicts: # internal/executor/application.go # internal/executor/reporter/job_event_reporter.go
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
d80tb7
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so you can configurable retry failed pods, much like the pending pod checks
The current caveat is that we only allow this for pods that have not started any containers, maybe we'll adjust this restriction at some point but we want to be conservative adding this feature for now
This feature for now is largely going to used to retry pods that have hit various Pod Allocation issues you can have (gpu drivers failing to allocate gpus, k8s failing to allocate containers etc)