Make bool's deserialization non-malleable
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small comment: instead of arbitrarily mutating the data, why not try mutating it to every possible byte value? That’ll remove the dependence on ark-ff |
|
That works for testing bool, but wouldn't generalize if we wanted to test this for any data type with a larger serialization. We have no other data type implemented in serialize (AFAIK) which has a non-1-to-1 encoding to test for atm, so maybe that point is moot. (Also for the current API to generalize well, we'd probably need to change Maybe it'd make sense to refactor this method out of tests, and do the above change, so other types (e.g. Fields) can check this if they wanted to? |
Pratyush
reviewed
Dec 7, 2020
Pratyush
approved these changes
Dec 11, 2020
Pratyush
changed the title
bool's deserialization non-malleable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the deserialization of bool non-malleable. Now the only strings that can be deserialized as a boolean are the encodings of
0u8, 1u8.closes: #95
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer