Add missing volume claim to user-container example #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
jeongukjae
requested review from
flaviuvadan,
sambhav and
elliotgunton
as code owners
jeongukjae
added
type:skip-changelog
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
=====================================
Coverage 45.9% 45.9%
=====================================
Files 60 60
Lines 4082 4082
Branches 857 857
=====================================
Hits 1875 1875
Misses 2175 2175
Partials 32 32 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jeongukjae
removed
the
type:skip-changelog
sambhav
approved these changes
Oct 21, 2024
elliotgunton
added
type:documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Tests addednot needed hereDocumentation/examples addednot needed hereDescription of PR
Following the volumes page in argo workflows document, updated user-container examples to have
volumeClaimTemplates.