Fix unclosed file warning #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_annotated_artifact_value was opening a file but not closing it, resulting in a ResourceWarning. Use `with` to ensure safe cleanup. Signed-off-by: Alice Purcell <alicederyn@gmail.com>
alicederyn
requested review from
flaviuvadan,
sambhav and
elliotgunton
as code owners
alicederyn
added
semver:patch
elliotgunton
approved these changes
Sep 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
=======================================
+ Coverage 81.7% 86.0% +4.2%
=======================================
Files 54 60 +6
Lines 4208 4041 -167
Branches 889 841 -48
=======================================
+ Hits 3439 3476 +37
+ Misses 574 392 -182
+ Partials 195 173 -22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently,
get_annotated_artifact_valueis opening a file but not closing it, resulting in a ResourceWarning in the__del__method.This PR just adds a
withblock to ensure safe cleanup.