chore: More opinionated linting #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexec
commented
Feb 10, 2021
•
alexec
commented
- Enable linters that are more opinioned about formatting (gci + gofumpt) esp. if they auto-fix. So we never have to think about this again.
- Enable linters that reveal potential bugs in the code (e.g. unparam)
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
commented
Feb 12, 2021
| @@ -1733,8 +1736,8 @@ func TestUnknownPodGCStrategy(t *testing.T) { | |||
|
|
|||
| assert.EqualError(t, err, "podGC.strategy unknown strategy 'Foo'") | |||
|
|
|||
| for _, strat := range []wfv1.PodGCStrategy{wfv1.PodGCOnPodCompletion, wfv1.PodGCOnPodSuccess, wfv1.PodGCOnWorkflowCompletion, wfv1.PodGCOnWorkflowSuccess} { | |||
| wf.Spec.PodGC.Strategy = strat | |||
| for _, start := range []wfv1.PodGCStrategy{wfv1.PodGCOnPodCompletion, wfv1.PodGCOnPodSuccess, wfv1.PodGCOnWorkflowCompletion, wfv1.PodGCOnWorkflowSuccess} { | |||
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
added a commit
that referenced
this pull request
Feb 15, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.