Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use red spinner color for terminating animation #5252

Merged
merged 1 commit into from
Jan 15, 2021
Merged

fix: use red spinner color for terminating animation #5252

merged 1 commit into from
Jan 15, 2021

Conversation

reginapizza
Copy link
Contributor

This will close issue #5159. Changes spinner icon color from cyan/blue (ARGO_RUNNING_COLOR) to it's own color, ARGO_TERMINATING_COLOR (#DE303D), a bright red.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

@reginapizza reginapizza force-pushed the terminatingCircleIssue5159 branch from a5ccfee to 1bdf4ac Compare January 15, 2021 00:22
@reginapizza
fix: use red spinner for terminating animation
1ea0411 
Signed-off-by: Regina Scott <rescott@redhat.com>
@reginapizza reginapizza force-pushed the terminatingCircleIssue5159 branch from 1bdf4ac to 1ea0411 Compare January 15, 2021 00:34
@codecov-io
Copy link

Codecov Report

Merging #5252 (1ea0411) into master (81497bb) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5252      +/-   ##
==========================================
+ Coverage   40.86%   40.90%   +0.04%     
==========================================
  Files         136      136              
  Lines       18453    18419      -34     
==========================================
- Hits         7540     7534       -6     
+ Misses       9834     9810      -24     
+ Partials     1079     1075       -4
Impacted Files Coverage Δ
server/application/application.go 27.71% <0.00%> (-1.36%) ⬇️
server/account/account.go 69.16% <0.00%> (+0.74%) ⬆️
controller/clusterinfoupdater.go 35.08% <0.00%> (+13.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81497bb...1ea0411. Read the comment docs.

rbreeze
rbreeze approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 5037a65 into argoproj:master Jan 15, 2021
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
@reginapizza @Shubhama19
fix: use red spinner for terminating animation (argoproj#5252)
02896c5 
Signed-off-by: Regina Scott <rescott@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbreeze rbreeze rbreeze approved these changes

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reginapizza @codecov-io @alexmt @rbreeze