Expand RBAC role to be able to create application events. Fix username claims extraction. #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e claims extraction.
I determined the UI is not making the correct request. It is making a request like: http://localhost:8080/api/v1/applications/guestbook-default/events?resourceName&resourceUID |
alexmt
approved these changes
Jul 31, 2018
|
Nevermind the URL is expected to work. Will merge these changes and let @alexmt figure out the rest. |
leoluz
added a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partial fix to issue #478. With this change, events can now be generated. But something is still preventing the listing from API server.
Also, the way we were extracting the username field from the claims, did not work when the user was logged in via SSO.