Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s dependency to v1.16 #2828

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Update k8s dependency to v1.16 #2828

merged 1 commit into from
Dec 11, 2019

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Dec 7, 2019 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to the README.
  • I've signed the CLA and my build is green (troubleshooting builds).

@jessesuen jessesuen force-pushed the update-k8s-1.16 branch 3 times, most recently from 799357c to 3874e74 Compare December 7, 2019 22:26
@codecov
Copy link

codecov bot commented Dec 7, 2019 •
edited
Loading

Codecov Report

Merging #2828 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2828      +/-   ##
==========================================
- Coverage   38.87%   38.82%   -0.06%     
==========================================
  Files         163      163              
  Lines       17563    17563              
  Branches      204      230      +26     
==========================================
- Hits         6828     6819       -9     
- Misses       9884     9892       +8     
- Partials      851      852       +1
Impacted Files Coverage Δ
util/health/health.go 60.76% <ø> (ø) ⬆️
server/account/account.go 43.75% <ø> (ø) ⬆️
util/diff/diff.go 61.73% <ø> (ø) ⬆️
controller/appcontroller.go 44.91% <0%> (-1.21%) ⬇️
ui/src/app/applications/components/utils.tsx 46.68% <0%> (ø) ⬆️
ui/src/app/shared/services/projects-service.ts 19.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2b7b1...0a426dc. Read the comment docs.

@jessesuen jessesuen force-pushed the update-k8s-1.16 branch 10 times, most recently from 9868474 to 3869317 Compare December 10, 2019 02:17
@jessesuen jessesuen marked this pull request as ready for review December 10, 2019 02:34
alexec
alexec reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once merged, it will become harder to easily and safely back-port to v1.3. Bear that in mind.

@jessesuen jessesuen merged commit 0ea0404 into argoproj:master Dec 11, 2019
@jessesuen jessesuen deleted the update-k8s-1.16 branch December 11, 2019 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@alexec alexec alexec left review comments

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jessesuen @alexmt @alexec @golangcibot