Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Support filter for configured and unchanged on SYNC STATUS view #20850

Merged
merged 3 commits into from
Nov 27, 2024
Merged

feat(ui): Support filter for configured and unchanged on SYNC STATUS view #20850

merged 3 commits into from
Nov 27, 2024

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Nov 19, 2024 •
edited
Loading

Fixes: #13457

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

No filter:

Screenshot 2024-11-19 at 6 07 10 PM

Filter configured

Screenshot 2024-11-19 at 6 07 33 PM

Filter unchanged
Screenshot 2024-11-20 at 11 47 34 AM

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Nov 19, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@aali309 aali309 marked this pull request as ready for review November 19, 2024 23:04
@aali309 aali309 requested a review from a team as a code owner November 19, 2024 23:04
@aali309 aali309 marked this pull request as draft November 19, 2024 23:05
@aali309 aali309 changed the title enhncement(ui): Support filter for configured and unchanged on SYNC STATUS view feat(ui): Support filter for configured and unchanged on SYNC STATUS view Nov 19, 2024
@aali309 aali309 force-pushed the supportFiltering branch 2 times, most recently from c468c88 to 21e42ef Compare November 20, 2024 17:54
@aali309 aali309 marked this pull request as ready for review November 20, 2024 18:11
ishitasequeira
ishitasequeira reviewed Nov 22, 2024
View reviewed changes
ui/src/app/applications/components/application-operation-state/application-operation-state.tsx Outdated
@@ -16,6 +16,7 @@ interface Props {
operationState: models.OperationState;
}
const buildResourceUniqueId = (res: Omit<models.ResourceRef, 'uid'>) => `${res.group}-${res.kind}-${res.version}-${res.namespace}-${res.name}`;
const MessageStatuses = ['configured', 'unchanged'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename MessageStatuses -> FilterableMessageStatuses

@aali309
added filter support for configured and unchanged
030ba23 
Signed-off-by: Atif Ali <atali@redhat.com>
@aali309
resolved issues
7703d6a 
Signed-off-by: Atif Ali <atali@redhat.com>
@aali309
rename MessageStatuses -> FilterableMessageStatuses
b317845 
Signed-off-by: Atif Ali <atali@redhat.com>
@ishitasequeira ishitasequeira merged commit 36d189c into argoproj:master Nov 27, 2024
28 checks passed
@aali309 aali309 deleted the supportFiltering branch November 28, 2024 17:48
@aali309 aali309 mentioned this pull request Dec 4, 2024
Merged
14 tasks
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@aali309 @adriananeci
feat(ui): Support filter for configured and unchanged on SYNC STA…
e0dabcc 
…TUS view (argoproj#20850)

Signed-off-by: Adrian Aneci <aneci@adobe.com>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
@aali309 @revitalbarletz
feat(ui): Support filter for configured and unchanged on SYNC STA…
0c22631 
…TUS view (argoproj#20850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

@jdedhia-chwy jdedhia-chwy jdedhia-chwy approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support filtering on configured/unchanged in sync status
4 participants
@aali309 @ishitasequeira @jdedhia-chwy @andrii-korotkov-verkada