❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@6d8d32f). Learn more about missing BASE report.

@@            Coverage Diff            @@
##             master   #20816   +/-   ##
=========================================
  Coverage          ?   55.16%           
=========================================
  Files             ?      324           
  Lines             ?    55268           
  Branches          ?        0           
=========================================
  Hits              ?    30486           
  Misses            ?    22165           
  Partials          ?     2617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Nice! Do you think we can add a few e2e tests?

I have TestSyncTimeout, but can also add end-to-end if necessary. Though I'm not sure they'd add more value, since they'd be replicating the logic from TestSyncTimeout. What do you think?

I have TestSyncTimeout, but can also add end-to-end if necessary. Though I'm not sure they'd add more value, since they'd be replicating the logic from TestSyncTimeout. What do you think?

I was thinking that deploying an application that will never leave progressing and being able to make sure it the sync status fails would be a good one to have. If you think the unit tests are solid, rock on!

After upgrading to the rc 5 version of 2.14.0, we tested this feature by adding the following configuration to argocd-cmd-params-cm:

controller.sync.timeout.seconds: '30'

However, even after reproducing the never-ending syncing state, it does not terminate after the specified timeout.
Could you advise if there is any misconfiguration on our end?

I suspect 30 may be too small. Can you try with a value which would be more practical like 900-1800?

I suspect 30 may be too small. Can you try with a value which would be more practical like 900-1800?

I attempted to set a 30-minute timeout, but it didn't work.

Ah, I think maybe it's because it keep retrying and counts each attempt as a separate sync? I can confirm that I observed this feature working in at least one case in my company. Can you try disabling infinite retries and see what happens?

Ah, I think maybe it's because it keep retrying and counts each attempt as a separate sync? I can confirm that I observed this feature working in at least one case in my company. Can you try disabling infinite retries and see what happens?

can i get the scenario where you tested this on, I will try to reproduce it ?

can i get the scenario where you tested this on, I will try to reproduce it ?

I don't have a repro :(

can i get the scenario where you tested this on, I will try to reproduce it ?

I don't have a repro :(

managed to reproduce a never ending sync state and observed the sync failing without any manual intervention

Tho the sync went on for 31 minutes when i set a 30 minute timeout, Is this normal?

this is one more scenario where i set the sync timeout for 15 minutes, looks like its working :)
but somehow if there are retries looks like it wont work if im not wrong

Tho the sync went on for 31 minutes when i set a 30 minute timeout, Is this normal?

I'm not sure, check out various status fields and see if the start timestamp is somewhat different than when the sync has started. I've noticed the sync initially is "waiting to start", so maybe that's not counted towards timeout.