Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prompting to confirm remove of repository credentials #20541

Merged

Conversation

pasha-codefresh
Copy link
Member

It allows for prompt behavior configuration through settings or flags. By default, prompts are disabled, ensuring no change to existing functionality. However, users can enable prompts for their CLI if desired.

Details here:

#19528

Signed-off-by: pashakostohrys <pavel@codefresh.io>
@pasha-codefresh pasha-codefresh requested a review from a team as a code owner October 26, 2024 07:55
Copy link

bunnyshell bot commented Oct 26, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@16e7517). Learn more about missing BASE report.
Report is 391 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/repocreds.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20541   +/-   ##
=========================================
  Coverage          ?   55.19%           
=========================================
  Files             ?      324           
  Lines             ?    55095           
  Branches          ?        0           
=========================================
  Hits              ?    30412           
  Misses            ?    22074           
  Partials          ?     2609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit eb6d2e6 into argoproj:master Oct 28, 2024
27 checks passed
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
…proj#20541)

* feat: add prompting to confirm remove of repository credentials

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* feat: add prompting to confirm remove of repository credentials

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants