feat: Adding more health checks for Keycloak, Postgres, Grafana, SolrCloud #20294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
|
Thanks for the PR! I see that some of the test resources YAMLs are hand-crafted. Would it be possible to use actual (redacted) CRs for each scenario? That'll improve test reliability and give us something to check against if/when health checks are modified to take more info into account. |
rezellme
force-pushed
the
health-checks
branch
from
0313f95 to
9ff6475
Compare
Hi Michael, I rebased and then force-pushed actual/redacted CRs. |
Signed-off-by: Remo Zellmer <rze@vizrt.com>
rezellme
force-pushed
the
health-checks
branch
from
9ff6475 to
f5b67a9
Compare
… GrafanaDatasource Signed-off-by: Remo Zellmer <rze@vizrt.com>
Signed-off-by: Remo Zellmer <rze@vizrt.com>
Signed-off-by: Remo Zellmer <rze@vizrt.com>
rezellme
force-pushed
the
health-checks
branch
from
f5b67a9 to
85dbf24
Compare
|
Oops, forgot the GrafanaDatasource part 👼. force-pushed again. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20294 +/- ##
==========================================
- Coverage 55.95% 55.94% -0.01%
==========================================
Files 322 322
Lines 44714 44714
==========================================
- Hits 25021 25017 -4
- Misses 17101 17104 +3
- Partials 2592 2593 +1 ☔ View full report in Codecov by Sentry. |
ali-hamza-noor
pushed a commit
to ali-hamza-noor/argo-cd
that referenced
this pull request
Oct 10, 2024
…na, SolrCloud (argoproj#20294) * feat(health): Add healtchcheck for acid.zalan.do/postgresql Signed-off-by: Remo Zellmer <rze@vizrt.com> * feat(health): Add healthcheck for grafana.integreatly.org/Grafana and GrafanaDatasource Signed-off-by: Remo Zellmer <rze@vizrt.com> * feat(health): Add healthcheck for k8s.keycloak.org/Keycloak Signed-off-by: Remo Zellmer <rze@vizrt.com> * feat(health): Add healthcheck for solr.apache.org/SolrCloud Signed-off-by: Remo Zellmer <rze@vizrt.com> --------- Signed-off-by: Remo Zellmer <rze@vizrt.com> Signed-off-by: alnoor <alihamzanoor99@gmail.com>
austin5219
pushed a commit
to austin5219/argo-cd
that referenced
this pull request
Oct 16, 2024
…na, SolrCloud (argoproj#20294) * feat(health): Add healtchcheck for acid.zalan.do/postgresql Signed-off-by: Remo Zellmer <rze@vizrt.com> * feat(health): Add healthcheck for grafana.integreatly.org/Grafana and GrafanaDatasource Signed-off-by: Remo Zellmer <rze@vizrt.com> * feat(health): Add healthcheck for k8s.keycloak.org/Keycloak Signed-off-by: Remo Zellmer <rze@vizrt.com> * feat(health): Add healthcheck for solr.apache.org/SolrCloud Signed-off-by: Remo Zellmer <rze@vizrt.com> --------- Signed-off-by: Remo Zellmer <rze@vizrt.com> Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
…na, SolrCloud (argoproj#20294) * feat(health): Add healtchcheck for acid.zalan.do/postgresql Signed-off-by: Remo Zellmer <rze@vizrt.com> * feat(health): Add healthcheck for grafana.integreatly.org/Grafana and GrafanaDatasource Signed-off-by: Remo Zellmer <rze@vizrt.com> * feat(health): Add healthcheck for k8s.keycloak.org/Keycloak Signed-off-by: Remo Zellmer <rze@vizrt.com> * feat(health): Add healthcheck for solr.apache.org/SolrCloud Signed-off-by: Remo Zellmer <rze@vizrt.com> --------- Signed-off-by: Remo Zellmer <rze@vizrt.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Contributing with a few more custom health-checks that we needed for our setup.
Checklist: