feat(custom healthchecks): add healthchecks for Gloo resources #11379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11379 +/- ##
==========================================
- Coverage 55.81% 55.80% -0.02%
==========================================
Files 320 320
Lines 44396 44396
==========================================
- Hits 24781 24776 -5
- Misses 17050 17057 +7
+ Partials 2565 2563 -2 ☔ View full report in Codecov by Sentry. |
zelig81
force-pushed
the
feat/add-gloo-custom-healthchecks
branch
from
ef0515c to
3b46aa1
Compare
Signed-off-by: Ilya Gorban <zelig81@users.noreply.github.com>
Signed-off-by: Ilya Gorban <zelig81@users.noreply.github.com>
Signed-off-by: Ilya Gorban <zelig81@users.noreply.github.com>
zelig81
force-pushed
the
feat/add-gloo-custom-healthchecks
branch
from
3b46aa1 to
0390604
Compare
crenshaw-dev
approved these changes
Sep 18, 2024
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
* feat(custom healthchecks): add healthchecks for Gloo resources Signed-off-by: Ilya Gorban <zelig81@users.noreply.github.com> * fix(gloo custom healthchecks): fix healthcheck and add older cases Signed-off-by: Ilya Gorban <zelig81@users.noreply.github.com> * feat(custom healthchecks): fix tabulation in Gloo resources lua files Signed-off-by: Ilya Gorban <zelig81@users.noreply.github.com> --------- Signed-off-by: Ilya Gorban <zelig81@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilya Gorban zelig81@users.noreply.github.com
Added health checks for almost all Gloo resources.
Since Gloo uses the same status indication on all resources, the health checks are the same, the only difference is in apiVersion and kind of the test objects. There are few of the resources (less than 20), so I generated them manually (to easy generation)
I took as an example this PR