Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Enhancements #112

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Performance Enhancements #112

merged 2 commits into from
Apr 29, 2021

Conversation

sdd
Copy link
Contributor

@sdd sdd commented Apr 29, 2021

  • eliminate calls to ArgminKV when there are no observers
  • make the timer optional
  • only create/append/destroy filename string when an iteration will write a checkpoint

See #111 for more detail.

sdd added 2 commits April 29, 2021 09:15
@sdd
feat: make timer optional. Optimise perf when no observers or checkpo…
9bee31e 
…ints
@sdd
feat: ArgminCheckpoint.store filename param changed to &str for flexi…
e5843f8 
…bility.

* perf: ArgminCheckpoint filename memoized inside ArgminCheckpoint for performance
stefan-k
stefan-k requested changes Apr 29, 2021
View reviewed changes
Copy link
Member

@stefan-k stefan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! I only have one minor suggestion.

src/core/serialization.rs Outdated Show resolved Hide resolved
@stefan-k stefan-k merged commit 16552cd into argmin-rs:master Apr 29, 2021
@stefan-k stefan-k mentioned this pull request May 2, 2023
Open
@stefan-k stefan-k mentioned this pull request Nov 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-k stefan-k stefan-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdd @stefan-k