Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no exception when tasmota-metrics is not found #22170

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Jason2866
Copy link
Collaborator

Description:

currently missing tasmota-metrics in Python env results in an ungracefully compile end.
With the PR compile is finished normally, just the metrics info is not shown.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.7
  • The code change is tested and works with Tasmota core ESP32 V.3.0.5
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866 Jason2866 merged commit 5d0cc81 into arendst:development Sep 19, 2024
59 checks passed
@Jason2866 Jason2866 deleted the metrics_failsafe branch September 19, 2024 16:31
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 7, 2024
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant