Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Code Analyzer one method per endpoint #25

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Add Code Analyzer one method per endpoint #25

merged 2 commits into from
Aug 7, 2020

Conversation

ppittle
Copy link
Contributor

@ppittle ppittle commented Jul 16, 2020 •
edited
Loading

#13

image

Remaining:

  • get a Code Fix Provider working
  • verify title/description copy
  • update readme.md

@ppittle ppittle mentioned this pull request Jul 16, 2020
Closed
@ppittle ppittle force-pushed the feature/13-analyzer-one-method-per-endpoint branch 4 times, most recently from 3e3bee3 to f8b6555 Compare July 17, 2020 09:21
@ppittle ppittle force-pushed the feature/13-analyzer-one-method-per-endpoint branch from f8b6555 to b519796 Compare July 27, 2020 08:14
@ppittle ppittle changed the title [WIP] Add Code Analyzer one method per endpoint Add Code Analyzer one method per endpoint Jul 27, 2020
@ppittle ppittle force-pushed the feature/13-analyzer-one-method-per-endpoint branch from b519796 to 2d83b95 Compare July 27, 2020 08:17
@ppittle
Copy link
Contributor Author

ppittle commented Jul 27, 2020

@ardalis - This is ready for you.

It introduces a new project/package Ardalis.ApiEndpoints.CodeAnalyzers that will need to be published.
Ardalis.ApiEndpoints will also need to have its version bumped and republished as it now takes a dependency on the Analyzers project. I did not bump the version.

Take a look at the dependency relationship between CodeAnalyzers and ApiEndpoints and make sure you're happy with ApiEndpoints depending on CodeAnalyzers. It feels counter intuitive but it seems to make dotnet pack a bit easier to work with as it will wire up the nuget references automagically. Not sure if there's an alternative approach, but this appears to get the job done.

@ardalis
Copy link
Owner

ardalis commented Jul 27, 2020

W00t! I'll tray and check it out later today! Thanks!

@ardalis ardalis merged commit 77a8082 into ardalis:master Aug 7, 2020
@ppittle ppittle deleted the feature/13-analyzer-one-method-per-endpoint branch August 8, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiesmaster tiesmaster tiesmaster left review comments

@ardalis ardalis ardalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppittle @ardalis @tiesmaster