Add cancellation token support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardalis
reviewed
Jul 14, 2020
| @@ -44,5 +46,25 @@ public async Task CreatesANewAuthor() | |||
| Assert.Equal(result.PluralsightUrl, newAuthor.PluralsightUrl); | |||
| Assert.Equal(result.TwitterAlias, newAuthor.TwitterAlias); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task GivenLongRunningCreateRequest_WhenTokenSourceCallsForCancellation_RequestIsTermainated() | |||
There was a problem hiding this comment.
Suggested change
| public async Task GivenLongRunningCreateRequest_WhenTokenSourceCallsForCancellation_RequestIsTermainated() | |
| public async Task GivenLongRunningCreateRequest_WhenTokenSourceCallsForCancellation_RequestIsTerminated() |
ardalis
reviewed
Jul 14, 2020
| @@ -34,5 +36,19 @@ public async Task ReturnsAuthorById() | |||
| Assert.Equal(firstAuthor.PluralsightUrl, result.PluralsightUrl); | |||
| Assert.Equal(firstAuthor.TwitterAlias, result.TwitterAlias); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task GivenLongRunningGetRequest_WhenTokenSourceCallsForCancellation_RequestIsTermainated() | |||
There was a problem hiding this comment.
Suggested change
| public async Task GivenLongRunningGetRequest_WhenTokenSourceCallsForCancellation_RequestIsTermainated() | |
| public async Task GivenLongRunningGetRequest_WhenTokenSourceCallsForCancellation_RequestIsTerminated() |
ardalis
reviewed
Jul 14, 2020
| @@ -30,5 +32,18 @@ public async Task ReturnsTwoGivenTwoAuthors() | |||
| Assert.NotNull(result); | |||
| Assert.Equal(SeedData.Authors().Count(), result.Count()); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task GivenLongRunningListRequest_WhenTokenSourceCallsForCancellation_RequestIsTermainated() | |||
There was a problem hiding this comment.
Suggested change
| public async Task GivenLongRunningListRequest_WhenTokenSourceCallsForCancellation_RequestIsTermainated() | |
| public async Task GivenLongRunningListRequest_WhenTokenSourceCallsForCancellation_RequestIsTerminated() |
ardalis
reviewed
Jul 14, 2020
| } | ||
|
|
||
| [Fact] | ||
| public async Task GivenLongRunningPaginatedListRequest_WhenTokenSourceCallsForCancellation_RequestIsTermainated() |
There was a problem hiding this comment.
Suggested change
| public async Task GivenLongRunningPaginatedListRequest_WhenTokenSourceCallsForCancellation_RequestIsTermainated() | |
| public async Task GivenLongRunningPaginatedListRequest_WhenTokenSourceCallsForCancellation_RequestIsTerminated() |
ardalis
reviewed
Jul 14, 2020
| @@ -44,5 +46,24 @@ public async Task UpdateAnExistingAuthor() | |||
| Assert.Equal(result.PluralsightUrl, authorPreUpdate.PluralsightUrl); | |||
| Assert.Equal(result.TwitterAlias, authorPreUpdate.TwitterAlias); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task GivenLongRunningUpdateRequest_WhenTokenSourceCallsForCancellation_RequestIsTermainated() | |||
There was a problem hiding this comment.
Suggested change
| public async Task GivenLongRunningUpdateRequest_WhenTokenSourceCallsForCancellation_RequestIsTermainated() | |
| public async Task GivenLongRunningUpdateRequest_WhenTokenSourceCallsForCancellation_RequestIsTerminated() |
|
Good catch, updated with latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #20, with accompanying updates to the sample project and additional unit tests.