Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple query string parameters #15

Closed
jeastham1993 opened this issue Apr 29, 2020 · 4 comments
Closed

Allow multiple query string parameters #15

jeastham1993 opened this issue Apr 29, 2020 · 4 comments

Comments

@jeastham1993
Copy link
Contributor

I can't seem to discover a way to provide multiple query string parameters into a single endpoint, the type params of BaseRequest only support a single request/response.

A use case being something like pagination

GET https://myapi/v1/transactions?page=1&per_page=10&query=1234

I'm happy to implement it, if you have any suggestions on how.
@ardalis
Copy link
Owner

ardalis commented Apr 29, 2020

I had someone else point out how to overcome this. I haven't had a chance to implement it but I'll track it down and do so.

@jeastham1993
Copy link
Contributor Author

If you manage to track it down send through the code and I'm happy to do the legwork.

@ardalis
Copy link
Owner

ardalis commented Apr 29, 2020

Try this: #6

ardalis pushed a commit that referenced this issue Apr 29, 2020
@jeastham1993
Add query parameter support #15 (#16)
a47bc9a 
* Add support for multiple query parameters #15

* Remove redundant pagination request model

* Functional tests for Create, Delete and Update #1

Co-authored-by: James Eastham <j.eastham1993@gmail.com>
@ardalis
Copy link
Owner

ardalis commented Apr 29, 2020

Fixed, thanks!

@ardalis ardalis closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ardalis @jeastham1993