-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Functional Tests for Author Endpoints #1
Comments
I'll take a shot at implementing these functional tests! 😃 |
Go for it! |
By the way, any estimate on turnaround time? |
@ardalis I finished the get and list tests, but I ran into some issues with the create, delete, and update tests. I can open the PR for reference, but my issue is the in memory database provider causes some synchronization issues when the tests run. So when I run the create test, the total count of Authors is incremented which breaks the list test. Same goes for delete tests when it decrements the Author list count. I would appreciate any thoughts or feedback on how to approach these functional tests. |
If you want to PR just the read-only method tests that's fine. If you want an example of some tests that I'm pretty sure work properly, look here: and also (older) here: |
Published the existing PR for get and list tests only for right now. If I have some additional availability over the next few days I'll gladly pick up the create, delete, and update tests if someone hasn't done them already. |
Happy to pick this up as well @ardalis for the create, update and delete methods |
Thanks! |
Use this as a model/starting point:
https://github.com/ardalis/CleanArchitecture/blob/master/tests/CleanArchitecture.FunctionalTests/Api/ApiToDoItemsControllerList.cs
The text was updated successfully, but these errors were encountered: