fix: fix useMountedState in hooks.ts not correct init leavingRef in StrictMode.
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value in React 18 StrictMode (cherry picked from commit e18d76c)
wonuanyangying
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
adaex
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
this pr is about fix
hooks.tsuseMountedStatenot working correctly in React 18 with StrictMode.StrictMode will render component twice, but in
useMountedStatedo not have code to re-initleavingRefwhen mounted again.Reference:
Case
when i using
Pickercomponent, its data will not correctly updated after selectPickerCellitems.Issue
related #291
Effected Component
imagepicker-viewpopover