Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

[ruby] Upgrade rubocop to version 1.27.0 #267

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Apr 9, 2022

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.26.0 → ~> 1.27.0) · Repo · Changelog

Release Notes

1.27.0

New features

  • #10500: Add new Lint/RefinementImportMethods cop. (@koic)
  • #10438: Add new Style/RedundantInitialize cop to check for unnecessary initialize methods. (@dvandersluis)

Bug fixes

  • #10464: Fix an incorrect autocorrect for Lint/IncompatibleIoSelectWithFiberScheduler when using IO.select with read (or write) argument and using return value. (@koic)
  • #10506: Fix an error for Style/RaiseArgs when raise with new method without receiver. (@koic)
  • #10479: Fix a false positive for Lint/ShadowingOuterLocalVariable conditional statement and block variable. (@ydah)
  • #10189: Fix --display-style-guide so it works together with --format offenses. (@jonas054)
  • #10465: Fix false positive for Naming/BlockForwarding when the block argument is assigned. (@dvandersluis)
  • #10491: Improve the handling of comments in Lint/EmptyConditionalBody, Lint/EmptyInPattern and Lint/EmptyWhen when AllowComments is set to true. (@Darhazer)
  • #10504: Fix a false positive for Lint/UnusedMethodArgument when using raise NotImplementedError with optional arguments. (@koic)
  • #10494: Fix a false positive for Style/HashSyntax when return with one line if condition follows (without parentheses). (@koic)
  • #10311: Fix false negative inside do..end for Layout/RedundantLineBreak. (@jonas054)
  • #10468: Fix a false positive for Style/FileWrite when a splat argument is passed to f.write. (@koic)
  • #10474: Fix a false positive for Style/DoubleNegation with EnforcedStyle: allowed_in_returns when inside returned conditional clauses. (@ydah)
  • #10388: Fix an incorrectly adds a disable statement for Layout/SpaceInsideArrayLiteralBrackets with --disable-uncorrectable. (@ydah)
  • #10489: Fix a false positive for Lint/LambdaWithoutLiteralBlock when using lambda with a symbol proc. (@koic)

Changes

  • #10191: Add MaxChainLength option to Style/SafeNavigation and the option is 2 by default. (@ydah)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 31 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Apr 9, 2022
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #267 (21384c4) into main (487ee1b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #267   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           33        33           
=========================================
  Hits            33        33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487ee1b...21384c4. Read the comment docs.

@ruebot ruebot merged commit 3d29201 into main Apr 9, 2022
@depfu depfu bot deleted the depfu/update/rubocop-1.27.0 branch April 9, 2022 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant