Fixed BTS-1543 #19715
Merged
Fixed BTS-1543 #19715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- client tools (e.g. arangoexport) don't refuse to start up with the error `output directory ... is not empty, use --overwrite true to overwrite the data in it if the output directory *only* contains the `ENCRYPTION` file. This is a special case, which can easily occur when invoking any of the client tools with wrong arguments. In this case no harm is done when allowing the tool to run anyway, even without the `--overwrite true` flag. This will potentially clobber the `ENCRYPTION` file, but it is safe to do because we restrict this to the situation when the directory *only* contains the `ENCRYPTION` file. - allow invoking client tools and arangod with `https://`- and `http://`- prefixed endpoints. This is more user-friendly than the previously supported `ssl://`- and `tcp://`-prefixed endpoints. End users are familiar with using `https://` and `http://` than our `ssl://` or `tcp://` endpoints. Internally, `https://` will be converted to `ssl://`, and `http://` will be converted to `tcp://`.
* Fixed BTS-1531: Async cancel Job returns different error messages. Unify error messages for canceled jobs (error code 21) to "request canceled". Previously, the server could return different messages, either "request canceled", "request has been canceled by user" or "handler canceled".
This reverts commit 95a2e00.
MBkkt
approved these changes
Sep 4, 2023
CryptoNinjaGeek
pushed a commit
that referenced
this pull request
Sep 12, 2023
* Fixed BTS-1543: - client tools (e.g. arangoexport) don't refuse to start up with the error `output directory ... is not empty, use --overwrite true to overwrite the data in it if the output directory *only* contains the `ENCRYPTION` file. This is a special case, which can easily occur when invoking any of the client tools with wrong arguments. In this case no harm is done when allowing the tool to run anyway, even without the `--overwrite true` flag. This will potentially clobber the `ENCRYPTION` file, but it is safe to do because we restrict this to the situation when the directory *only* contains the `ENCRYPTION` file. - allow invoking client tools and arangod with `https://`- and `http://`- prefixed endpoints. This is more user-friendly than the previously supported `ssl://`- and `tcp://`-prefixed endpoints. End users are familiar with using `https://` and `http://` than our `ssl://` or `tcp://` endpoints. Internally, `https://` will be converted to `ssl://`, and `http://` will be converted to `tcp://`. * fix CHANGELOG order * BTS-1531 * Fixed BTS-1531: Async cancel Job returns different error messages. Unify error messages for canceled jobs (error code 21) to "request canceled". Previously, the server could return different messages, either "request canceled", "request has been canceled by user" or "handler canceled". * Revert "BTS-1531" This reverts commit 95a2e00. * fix tests
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Fixed BTS-1543: https://arangodb.atlassian.net/browse/BTS-1543
client tools (e.g. arangoexport) don't refuse to start up with the error
output directory ... is not empty, use --overwrite trueto overwrite the data in it if the output directory only contains theENCRYPTIONfile. This is a special case, which can easily occur when invoking any of the client tools with wrong arguments. In this case no harm is done when allowing the tool to run anyway, even without the--overwrite trueflag. This will potentially clobber theENCRYPTIONfile, but it is safe to do because we restrict this to the situation when the directory only contains theENCRYPTIONfile.allow invoking client tools and arangod with
https://- andhttp://- prefixed endpoints. This is more user-friendly than the previously supportedssl://- andtcp://-prefixed endpoints. End users are familiar with usinghttps://andhttp://than ourssl://ortcp://endpoints. Internally,https://will be converted tossl://, andhttp://will be converted totcp://.💩 Bugfix
🍕 New feature
🔥 Performance improvement
🔨 Refactoring/simplification
Checklist
Related Information