Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sniff rta makedata #19461

Merged
merged 7 commits into from
Jul 25, 2023
Merged

Feature/sniff rta makedata #19461

merged 7 commits into from
Jul 25, 2023

Conversation

dothebart
Copy link
Contributor

Scope & Purpose

  • refresh RTA makedata to a stage that adds logging to foxx crud

  • send error messages via arangosh logfile to testfailurest.txt

  • enable sniffing

  • 💩 Bugfix

  • 🍕 New feature

@dothebart dothebart requested a review from jsteemann July 24, 2023 15:00
@dothebart dothebart requested a review from a team as a code owner July 24, 2023 15:00
@cla-bot cla-bot bot added the cla-signed label Jul 24, 2023
@jsteemann jsteemann added this to the devel milestone Jul 24, 2023
jsteemann
jsteemann approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in js/ and tests/ LGTM.
I did not look at the changes in 3rdParty/rta-makedata.

naushniki
naushniki approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@naushniki naushniki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 merged commit 1d2ef3d into devel Jul 25, 2023
@KVS85 KVS85 deleted the feature/sniff-rta-makedata branch July 25, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naushniki naushniki naushniki approved these changes

@jsteemann jsteemann jsteemann approved these changes

Assignees

@dothebart dothebart

Labels
3 - Testing cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
4 participants
@dothebart @jsteemann @naushniki @KVS85