Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --database.max-databases #19417

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Add --database.max-databases #19417

merged 4 commits into from
Jul 14, 2023

Conversation

jsteemann
Copy link
Contributor

@jsteemann jsteemann commented Jul 11, 2023

Scope & Purpose

  • Added startup option --database.max-databases to limit the maximum number of databases that can exist in parallel on a deployment. This option can be used to limit resources used by database objects. If the option is used and there already exist as many databases as configured by this option, any attempt to create an additional database will fail with error 32 (ERROR_RESOURCE_LIMIT). Additional databases can then only be created if other databases are dropped first. The default value for this option is unlimited, so technically an arbitrary amount of databases can be created (although effectively the number of databases is limited by memory and processing resources).
  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

Related Information

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

* Added startup option `--database.max-databases` to limit the maximum number
  of databases that can exist in parallel on a deployment. This option can be
  used to limit resources used by database objects. If the option is used and
  there already exist as many databases as configured by this option, any
  attempt to create an additional database will fail with error 32
  (`ERROR_RESOURCE_LIMIT`). Additional databases can then only be created if
  other databases are dropped first.
  The default value for this option is unlimited, so technically an arbitrary
  amount of databases can be created (although effectively the number of
  databases is limited by memory and processing resources).
@jsteemann jsteemann added this to the devel milestone Jul 11, 2023
@jsteemann jsteemann requested a review from a team as a code owner July 11, 2023 09:47
@cla-bot cla-bot bot added the cla-signed label Jul 11, 2023
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maierlars maierlars merged commit 41ee162 into devel Jul 14, 2023
@maierlars maierlars deleted the feature/max-number-of-databases branch July 14, 2023 07:11
jsteemann added a commit that referenced this pull request Jul 18, 2023
* Added startup option `--database.max-databases` to limit the maximum number
  of databases that can exist in parallel on a deployment. This option can be
  used to limit resources used by database objects. If the option is used and
  there already exist as many databases as configured by this option, any
  attempt to create an additional database will fail with error 32
  (`ERROR_RESOURCE_LIMIT`). Additional databases can then only be created if
  other databases are dropped first.
  The default value for this option is unlimited, so technically an arbitrary
  amount of databases can be created (although effectively the number of
  databases is limited by memory and processing resources).
KVS85 pushed a commit that referenced this pull request Jul 19, 2023
* Add `--database.max-databases` (#19417)

* Added startup option `--database.max-databases` to limit the maximum number
  of databases that can exist in parallel on a deployment. This option can be
  used to limit resources used by database objects. If the option is used and
  there already exist as many databases as configured by this option, any
  attempt to create an additional database will fail with error 32
  (`ERROR_RESOURCE_LIMIT`). Additional databases can then only be created if
  other databases are dropped first.
  The default value for this option is unlimited, so technically an arbitrary
  amount of databases can be created (although effectively the number of
  databases is limited by memory and processing resources).

* Update arangod/RestServer/DatabaseFeature.cpp

Co-authored-by: Heiko <hkernbach@users.noreply.github.com>

---------

Co-authored-by: Heiko <hkernbach@users.noreply.github.com>
@jsteemann jsteemann mentioned this pull request Jul 27, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants