Revert "fix races in in-memory cache system (#18243)" #18479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ebb6b47.
MBkkt
approved these changes
Mar 28, 2023
| SpinUnlocker shutdownUnguard(SpinUnlocker::Mode::Write, _shutdownLock); | ||
|
|
||
| // sleep a bit without holding the locks | ||
| std::this_thread::sleep_for(std::chrono::microseconds(20)); |
There was a problem hiding this comment.
Btw. why did you change it in reverted commit?
Because additional lock?
There was a problem hiding this comment.
I reverted the entire previous commit.
The version before had known issues, but these were probably less severe than the issues introduced by the commit that is now reverted.
There was a problem hiding this comment.
I understand but just curios why in reverted version you decide to increase sleep_for time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This reverts commit ebb6b47.
This change had unintended side effects.
Reverting the commit may bring back assertion failures in the in-memory cache in maintainer mode during Jenkins test runs.
Checklist
Related Information