Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PREGEL bugfix] Move log before return #18474

Merged
merged 1 commit into from
Mar 28, 2023
Merged

[PREGEL bugfix] Move log before return #18474

merged 1 commit into from
Mar 28, 2023

Conversation

jvolmer
Copy link
Contributor

@jvolmer jvolmer commented Mar 28, 2023

Moves a log statement before a return statement, which resulted in spurious errors.

@jvolmer jvolmer added the 3 Pregel Graph processing label Mar 28, 2023
@jvolmer jvolmer requested review from neunhoef and a team March 28, 2023 08:24
@jvolmer jvolmer self-assigned this Mar 28, 2023
@cla-bot cla-bot bot added the cla-signed label Mar 28, 2023
neunhoef
neunhoef approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This fixes compilation with gcc 11.2.0 for me. Thanks!

@markuspf markuspf merged commit 2f0a497 into devel Mar 28, 2023
@markuspf markuspf deleted the bugfix/move-log-before-return branch March 28, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@jvolmer jvolmer

Labels
3 Pregel Graph processing cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvolmer @neunhoef @markuspf