Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make access to ClientFeature settings thread-safe #18451

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

make access to ClientFeature settings thread-safe

this is now required (in devel only) after a recent change that allows accessing the settings for the client tools from a different thread (telemetrics background thread).

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.10: -
    • Backport for 3.9: -
    • Backport for 3.8: -

Related Information

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

this is now required after a recent change that allows accessing the
settings for the client tools from a different thread (telemetrics
background thread).
@jsteemann jsteemann added this to the devel milestone Mar 27, 2023
@jsteemann jsteemann requested a review from a team as a code owner March 27, 2023 08:56
@cla-bot cla-bot bot added the cla-signed label Mar 27, 2023
@jsteemann jsteemann requested a review from cpjulia March 27, 2023 10:48
Copy link
Contributor

@cpjulia cpjulia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsteemann jsteemann merged commit 485d63c into devel Mar 27, 2023
@jsteemann jsteemann deleted the bug-fix/thread-safety-for-client-tools-settings branch March 27, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants