[GORDO-1552] Implement conductor canceled state #18423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspf
changed the title
jvolmer
force-pushed
the
feature/gordo-1550-implement-storing-state-in-conductor-actor
branch
2 times, most recently
from
4bb035a to
79c28b5
Compare
jvolmer
force-pushed
the
feature/gordo-1552-conductor-canceled-state
branch
from
6d221bd to
c0ab579
Compare
An error occurred while trying to automatically change base from
feature/gordo-1550-implement-storing-state-in-conductor-actor
to
devel
March 24, 2023 09:04
jvolmer
force-pushed
the
feature/gordo-1552-conductor-canceled-state
branch
from
c0ab579 to
b6e5eba
Compare
5 tasks
jvolmer
force-pushed
the
feature/gordo-1552-conductor-canceled-state
branch
from
b6e5eba to
4551396
Compare
jvolmer
changed the base branch from
feature/gordo-1550-implement-storing-state-in-conductor-actor
to
devel
Cleanup in AQLResultsAvailable state
jvolmer
force-pushed
the
feature/gordo-1552-conductor-canceled-state
branch
from
4551396 to
2524de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cancel state that cleans up worker and spawn actors (meaning they are set to finished, such that garbage collection can delete them).
I changed all other final states (Done, FatalError and AQLResultsAvailable) do the same cleanup.
When the cleanup is finished in all these states, the conductor changes its execution state to Finished state, which cleans up the conductor.