Replace arangodb::containers::SmallVector with std::span and absl::InlinedVector #16216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBkkt
force-pushed
the
feature/remove-small-vector
branch
from
ee7bc8a to
7f396e4
Compare
jsteemann
reviewed
May 3, 2022
jsteemann
reviewed
May 3, 2022
jsteemann
reviewed
May 3, 2022
jsteemann
reviewed
May 3, 2022
MBkkt
force-pushed
the
feature/remove-small-vector
branch
2 times, most recently
from
fff8e10 to
7e1ed82
Compare
jsteemann
reviewed
May 4, 2022
gnusi
approved these changes
May 5, 2022
MBkkt
force-pushed
the
feature/remove-small-vector
branch
from
7e1ed82 to
4e5943b
Compare
Also make common using declaration for it
MBkkt
force-pushed
the
feature/remove-small-vector
branch
from
4e5943b to
5365e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Replace our own primitives with well tested (also nice performance) from 3rdParty library.
Also I think
std::span<T const>probably always better thenSomeContainer<T> const&Checklist
Related Information
(Please reference tickets / specification / other PRs etc)