Scope & Purpose

This PR fixes the error messages on the client requests of arangorestore displaying passwords in plain text, trimming the json fields from the payload that display the password.
The server code still has to be changed and would require some extra thought into it.
Examples of error messages displaying the password in plain text, as in the ticket https://arangodb.atlassian.net/browse/BTS-580:

2021-09-13T15:45:52Z [4120] ERROR [7a35f] {restore} Could not create database '😀': got invalid response from server: HTTP 400: 'database name invalid' while executing creating database' with this payload: '{"name":"😀","options":{"replicationFactor":1},"users":[{"username":"root","passwd":"hustensaft"}]}'
2021-09-13T15:45:52Z [4120] ERROR [cb69f] {restore} got invalid response from server: HTTP 400: 'database name invalid' while executing creating database' with this payload: '{"name":"😀","options":{"replicationFactor":1},"users":[{"username":"root","passwd":"hustensaft"}]}'

• 💩 Bugfix (requires CHANGELOG entry)
• 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
• 🔥 Performance improvement
• 🔨 Refactoring/simplification
• 📖 CHANGELOG entry made

Backports:

No backports required.

Related Information

• Docs PR:
• Enterprise PR:
• GitHub issue / Jira ticket number: https://arangodb.atlassian.net/browse/BTS-622
• Design document:

Testing & Verification

• This change is a trivial rework / code cleanup without any test coverage.
• The behavior in this PR was manually tested
• This change is already covered by existing tests, such as (please describe tests).
• This PR adds tests that were used to verify all changes:
  • Added new C++ Unit tests Obs.: actually edits an existing test
  • Added new integration tests (e.g. in shell_server / shell_server_aql)
  • Added new resilience tests (only if the feature is impacted by failovers)
• There are tests in an external testing repository:
• I ensured this code runs with ASan / TSan or other static verification tools