Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed AUTO testsuite detection #14303

Merged
merged 1 commit into from
Jun 1, 2021
Merged

fixed AUTO testsuite detection #14303

merged 1 commit into from
Jun 1, 2021

Conversation

hkernbach
Copy link
Member

Scope & Purpose

Fixed AUTO testsuite detection

  • 💩 Bugfix (requires CHANGELOG entry)

Backports:

  • No backports required

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as (please describe tests).
  • This PR adds tests that were used to verify all changes:
    • Added new C++ Unit tests
    • Added new integration tests (e.g. in shell_server / shell_server_aql)
    • Added new resilience tests (only if the feature is impacted by failovers)
  • There are tests in an external testing repository:
  • I ensured this code runs with ASan / TSan or other static verification tools

@hkernbach hkernbach requested a review from mchacki June 1, 2021 15:42
mchacki
mchacki approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchacki mchacki merged commit ec8b8f3 into devel Jun 1, 2021
@mchacki mchacki deleted the bug-fix/fix-auto-testsuite-detection branch June 1, 2021 15:43
jsteemann added a commit that referenced this pull request Jun 1, 2021
@jsteemann
include fix from #14303
764a163
jsteemann added a commit that referenced this pull request Jun 1, 2021
@jsteemann
include fix from #14303
fd1b3cb
KVS85 added a commit that referenced this pull request Aug 4, 2021
@jsteemann @KVS85 @fceller
Added tests for dual LDAP feature (3.8) (#14299)
dd71e3f 
* added tests for dual LDAP feature

* include fix from #14303

* fixed path

Co-authored-by: Vadim Kondratyev <vadim@arangodb.com>
Co-authored-by: Frank Celler <frank@arangodb.com>
KVS85 added a commit that referenced this pull request Aug 4, 2021
@jsteemann @KVS85 @fceller
Added tests for dual LDAP feature (3.7) (#14301)
e2c9403 
* added dual LDAP tests

* include fix from #14303

* fixed path

* fixed missing endpoints

Co-authored-by: Vadim Kondratyev <vadim@arangodb.com>
Co-authored-by: Frank Celler <frank@arangodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchacki mchacki mchacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hkernbach @mchacki