change feature order so that ServerIdFeature is before ReplicationFeature #13743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture the latter requires the former for non-cluster replication
8 tasks
8 tasks
Merged
8 tasks
mchacki
pushed a commit
that referenced
this pull request
Mar 26, 2021
elfringham
pushed a commit
to elfringham/arangodb
that referenced
this pull request
Apr 20, 2021
elfringham
pushed a commit
to elfringham/arangodb
that referenced
this pull request
Apr 20, 2021
…ationFeature (arangodb#13743)" (arangodb#13772) This reverts commit 48dba7d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Change feature order so that ServerIdFeature is before ReplicationFeature.
The latter requires the former for non-cluster replication.
It is unclear yet if this change is helpful, it is just an attempt to get rid of a particular bug reported by @dothebart.
Th effects of this PR need to be manually tested with an official release build.
Backports:
Testing & Verification