Do not create index estimator objects for proxy collection objects #13506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do no create index estimator objects for proxy collection objects on coordinators and DB servers. Proxy objects are created on coordinator and DB servers for all shards, and they also make index objects available. In order to reduce the memory usage by these objects, we don't create any index estimator objects for indexes in those proxy objects. Index estimators usually take several KB of memory each, so not creating them will pay out for higher numbers of collections/shards.
jsteemann
commented
Feb 7, 2021
|
Tests blue |
mchacki
approved these changes
Feb 8, 2021
8 tasks
elfringham
pushed a commit
to elfringham/arangodb
that referenced
this pull request
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Do no create index estimator objects for proxy collection objects on coordinators and DB servers. Proxy objects are created on coordinators and DB servers for all shards, and they also make index objects available. In order to reduce the memory usage by these objects, we don't create any index estimator objects for indexes in those proxy objects. Index estimators usually take several KB of memory each, so not creating them will pay out for higher numbers of collections/shards.
Backports:
Testing & Verification
Link to Jenkins PR run:
http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/13890/