remove multiple debug functions for producing backtraces. #13469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, make CrashHandler::logBacktrace() available to write a backtrace of the current thread into the log. Calling this function should work on Linux, because there we build with libunwind support by default, and this can produce backtraces even for our static builds using libmusl (in contrast to `backtrace()`, which is a no-op there). In addition, using `CrashHandler::logBacktrace()` does not require to compile with the `-DUSE_BACKTRACE=On` CMake option. It is likely that the change made by this PR removes backtrace capabilities for MacOS and Windows, but it looks like those were only enabled previously when compiling with `-DUSE_BACKTRACE=On`, which is unlikely. To finalize this PR, we need to decide whether these potential restrictions are ok for us, and if so, we can also remove the `USE_BACKTRACE` CMake variable and remove the one or two remainders that use the `ARNAGODB_ENABLE_BACKTRACE` define in the code.
dothebart
reviewed
Feb 2, 2021
dothebart
approved these changes
Feb 2, 2021
|
Tests blue |
dothebart
approved these changes
Feb 2, 2021
|
As discussed with @mpoeter and @dothebart offline, we will not add Windows stacktrace logging, but instead we will try to leverage minidumps in case an unhandled exception flies by. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Remove multiple debug functions for producing backtraces.
Instead, make CrashHandler::logBacktrace() available to write a
backtrace of the current thread into the log.
Calling this function should work on Linux, because there we build with
libunwind support by default, and this can produce backtraces even for
our static builds using libmusl (in contrast to
backtrace(), which isa no-op there). In addition, using
CrashHandler::logBacktrace()doesnot require to compile with the
-DUSE_BACKTRACE=OnCMake option.It is likely that the change made by this PR removes backtrace
capabilities for MacOS and Windows, but it looks like those were only
enabled previously when compiling with
-DUSE_BACKTRACE=On, which isunlikely.
In addition, this PR removes the
USE_BACKTRACECMake variable and alsothe internal
ARANGODB_ENABLE_BACKTRACEdefine that was enabled by thisvariable.
The
USE_BACKTRACECMake option does not seem to have been documented.So this is likely an internal change only.
Backports:
Testing & Verification
Link to Jenkins PR run:
http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/13816/