re-allow VST connections in arangosh #12915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was broken temporarily during unreleased 3.7.5.
|
Tests blue |
dothebart
approved these changes
Oct 28, 2020
dothebart
reviewed
Oct 28, 2020
| }); | ||
|
|
||
| print(CYAN + 'Shutting down...' + RESET); | ||
| let shutdown = pu.shutdownInstance(instanceInfo, Object.assign(options, {useKillExternal: true})); |
There was a problem hiding this comment.
shouldn't this arangosh (that runs this test) still be able to connect to the server, and hence be able to use the regular shutdown command?
There was a problem hiding this comment.
I don't understand the question.
We are starting a few server instances in the endpoints test, because the server instances use different options.
For each server instance, we run mutliple arangosh tests, e.g.
- server instance1
- arangosh1
- arangosh2
- arangosh3
- server instance2
- arangosh4
- arangosh5
- arangosh6
...
The shutdown command in the test was actually there before, and I didn't modify it.
What is the exact problem with it?
|
Tests blue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This was broken temporarily during unreleased 3.7.5 development via #12885.
Backports:
Testing & Verification
http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/12479/