Fix isAdminUser. #11326
Merged
Fix isAdminUser. #11326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odb into bug-fix/admin-perms
jsteemann
reviewed
Mar 24, 2020
| @@ -1049,7 +1049,7 @@ Result RestReplicationHandler::processRestoreCollection(VPackSlice const& collec | |||
| return Result(); | |||
| } | |||
|
|
|||
| ExecContextSuperuserScope escope(ExecContext::current().isAdminUser()); | |||
| ExecContextSuperuserScope escope(ExecContext::current().isAdminUser() || !ServerState::readOnly()); | |||
There was a problem hiding this comment.
Should this this really be an ||? I would have expected &&.
There was a problem hiding this comment.
LOL, I have done this correctly in 3 places but in this one I made a boolean mistake.
Thanks for catching this!
jsteemann
reviewed
Mar 24, 2020
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
…odb into bug-fix/admin-perms
|
Still need to run |
|
|
ObiWahn
added a commit
that referenced
this pull request
Mar 25, 2020
…telisting * origin/devel: (80 commits) Feature/aql subquery execution block impl execute implementation batch sub queries (#11318) Fix isAdminUser. (#11326) Bug fix/fixes 20200318 (#11319) updated CHANGELOG Feature/out of search in range (#11324) fix "fix" for collection figures (#11323) updated CHANGELOG compilation fixes for clang-10s more strict checking (#11316) fix failing query (#11317) KShortestPathsExecutor must reset its KShortestPathFinder, including all caches. (#11312) Feature/aql subquery execution block impl execute implementation expected number of rows (#11274) Add DTRACE points to measure request timings. (#11245) USE_STRICT_OPENSSL is Off by default Fix usesRevisionAsDocumentId population and add syncByRevision flag (#11314) Traversal Bugfix (#11310) Bug fix/issue 11275 (#11299) added simple test (#11301) Fix some typos (#10173) Documentation/typos 2020-01-24 (#10975) Update CHANGELOG ...
ObiWahn
added a commit
that referenced
this pull request
Mar 27, 2020
…ql-functions * origin/devel: Bug fix/schema validation return code (#11341) Fix explainer output when restricting collections (#11338) remove tabstops Improve endpoint handling. (#11236) revert HTTP return code change for user API, add tests (#11331) remove unused header files (#11320) Feature/aql subquery execution block impl execute implementation batch sub queries (#11318) Fix isAdminUser. (#11326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attacks the problem that if a cluster is in read-only mode, no
user (except the superuser) had RW access to the system db. Therefore,
isAdminUser was returning false.