Feature/aql subquery execution block impl execute implementation batch sub queries #11318

mchacki · 2020-03-20T15:19:40Z

Pull Request Guidelines

Pull requests are an essential collaborative tool for modern software development.

The below list is intended to help you figure out whether your code is ready to be reviewed
and merged into ArangoDB. The overarching goal is to:

Reduce the amount of recurring defects
Reduce the impact to the other developer’s time and energy spent on defects in your code
Increase the overall autonomy and productivity of individual developers

Acceptance Checklist

The below list is not exhaustive, think thoroughly whether the provided information is sufficient.
Remove options that do not apply

Scope & Purpose

(Can you describe what functional change your PR is trying to effect?)

Improvement for devel-branch (i.e. no need for backports?)
The behavior change can be verified via automatic tests

Testing & Verification

This change is already covered by existing tests, such as (please describe tests).
This PR adds tests that were used to verify all changes:

Added new C++ Unit Tests (Either GoogleTest or Catch-Test)

Jenkins

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9123/

…ExecutionBlockImpl (not complete, only skip path) everything compiles, but is not tested

…nd with variants everywhere.

…pose a DataRange, this might not be the correct one every where

…y and SingleRowFetcher. Both untested and yet incomplete, they will only work for MVP.

…SubqueryOperationsStack

…ction + test

…Rows function + test" This reverts commit 2368252.

…/arangodb/ArangoDB into feature/AqlSubqueryOperationsStack

…ough. This state is broken in the sense that a server does not boot with it and catch tests are broken

…/arangodb/ArangoDB into feature/AqlSubqueryOperationsStack

…e locally green, however there is at least one query still red (on ShadowRows)

…erate branch

This reverts commit aa275b4.

…/arangodb/ArangoDB into feature/AqlSubqueryOperationsStack

…re/AqlSubqueryExecutionBlockImplExecuteImplementation

…kInputRange

…ndle ShadowRows properly

…re/AqlSubqueryExecutionBlockImplExecuteImplementation-batchSubQueries

…id continous fetching if the client does not do a continuous fetching

…re/AqlSubqueryExecutionBlockImplExecuteImplementation-batchSubQueries

… others...

…re/AqlSubqueryExecutionBlockImplExecuteImplementation-batchSubQueries

mchacki · 2020-03-23T09:24:27Z

Jenkins after "fixing" unused variable issue:

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/9129/

is blue

markuspf

There are a few comments and one bug to be addressed.

arangod/Aql/AqlCallList.h

arangod/Aql/AqlCallList.cpp

arangod/Aql/AqlCallStack.cpp

arangod/Aql/AqlCallList.cpp

tests/Aql/SingleRowFetcherTest.cpp

tests/Aql/SubqueryStartExecutorTest.cpp

arangod/Aql/ExecutionBlockImpl.cpp

…re/AqlSubqueryExecutionBlockImplExecuteImplementation-batchSubQueries

Thank you for spotting and correcting my bad English typing skills Co-Authored-By: Markus Pfeiffer <markuspf@users.noreply.github.com>

…rence more clearly, thanks for finding this in review

…alize the truth... there is no if.

mchacki · 2020-03-24T17:01:18Z

Applied all review changes.
New Jenkins:
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9149/

markuspf

LGTM, bar a couple of typos which I suggested correcting

arangod/Aql/AqlCallList.h

arangod/Aql/ExecutionBlockImpl.cpp

arangod/Aql/SubqueryStartExecutor.cpp

Thanks again for fixing my typos Co-Authored-By: Markus Pfeiffer <markuspf@users.noreply.github.com>

Co-Authored-By: Markus Pfeiffer <markuspf@users.noreply.github.com>

…telisting * origin/devel: (80 commits) Feature/aql subquery execution block impl execute implementation batch sub queries (#11318) Fix isAdminUser. (#11326) Bug fix/fixes 20200318 (#11319) updated CHANGELOG Feature/out of search in range (#11324) fix "fix" for collection figures (#11323) updated CHANGELOG compilation fixes for clang-10s more strict checking (#11316) fix failing query (#11317) KShortestPathsExecutor must reset its KShortestPathFinder, including all caches. (#11312) Feature/aql subquery execution block impl execute implementation expected number of rows (#11274) Add DTRACE points to measure request timings. (#11245) USE_STRICT_OPENSSL is Off by default Fix usesRevisionAsDocumentId population and add syncByRevision flag (#11314) Traversal Bugfix (#11310) Bug fix/issue 11275 (#11299) added simple test (#11301) Fix some typos (#10173) Documentation/typos 2020-01-24 (#10975) Update CHANGELOG ...

* origin/devel: Feature/aql subquery execution block impl execute implementation batch sub queries (#11318) Fix isAdminUser. (#11326) Bug fix/fixes 20200318 (#11319) updated CHANGELOG Feature/out of search in range (#11324) fix "fix" for collection figures (#11323)

…ql-functions * origin/devel: Bug fix/schema validation return code (#11341) Fix explainer output when restricting collections (#11338) remove tabstops Improve endpoint handling. (#11236) revert HTTP return code change for user API, add tests (#11331) remove unused header files (#11320) Feature/aql subquery execution block impl execute implementation batch sub queries (#11318) Fix isAdminUser. (#11326)

mchacki and others added 30 commits October 22, 2019 16:43

Added first draft of AqlCallObject

35fe0e5

Added AqlItemBlockInputRange

ead968c

Added Header file for AqlCallStack with comments. No implementation yet.

7c6bcba

Added AqlCallStack first draft implementation. Made everything compile

22d2977

Added empty dummy stubs for execute() in ExecutionBlock

3ab4488

Implementation of new API in FilterExecutor. Rough implementation in …

b079d78

…ExecutionBlockImpl (not complete, only skip path) everything compiles, but is not tested

Fixed off by one error in InputRange. Fixed FilterExecutor

eb120a0

Added some more tests if executor cannot fulfill atMost

cb2cef2

Added heplper functions to the AqlCall struct to avoid mangeling arou…

a46941e

…nd with variants everywhere.

Add a member DataRange to ExecutionBlockImpl. Also now all Fetcher ex…

e248e45

…pose a DataRange, this might not be the correct one every where

Added preliminary minimal implementation of execute to DependencyProx…

c40cfc0

…y and SingleRowFetcher. Both untested and yet incomplete, they will only work for MVP.

Merge branch 'devel' of github.com:arangodb/arangodb into feature/Aql…

dccbbcf

…SubqueryOperationsStack

added first implementation of count collect datarange produceRows fun…

2368252

…ction + test

Revert "added first implementation of count collect datarange produce…

acb414f

…Rows function + test" This reverts commit 2368252.

Merge branch 'feature/AqlSubqueryOperationsStack' of ssh://github.com…

b66f314

…/arangodb/ArangoDB into feature/AqlSubqueryOperationsStack

Merge branch 'devel' into feature/AqlSubqueryOperationsStack

5b0b8ce

First draft of execute implementation, not yet handling ShadowRows th…

e0205b5

…ough. This state is broken in the sense that a server does not boot with it and catch tests are broken

Merge branch 'feature/AqlSubqueryOperationsStack' of ssh://github.com…

3eff385

…/arangodb/ArangoDB into feature/AqlSubqueryOperationsStack

First working draft of execute() call in ExecutionBlockImpl. Tests ar…

96c0fda

…e locally green, however there is at least one query still red (on ShadowRows)

Removed non finished implementation from this Branch. It moved to sep…

4d019a1

…erate branch

working - not done yet

aa275b4

Revert "working - not done yet"

fd33b7f

This reverts commit aa275b4.

Intermediate devel pull, might not compile

4d030f4

Finally merged with latest devel, seems to work

0300467

Merge branch 'feature/AqlSubqueryOperationsStack' of ssh://github.com…

907628e

…/arangodb/ArangoDB into feature/AqlSubqueryOperationsStack

Merge branch 'devel' of ssh://github.com/arangodb/ArangoDB into featu…

11be23e

…re/AqlSubqueryExecutionBlockImplExecuteImplementation

first implementation of a ShadowRow fetching interface on AqlItemBloc…

c703b11

…kInputRange

single row fetcher, execute + tests

7911767

Merge

45f7771

Fixed SingleRowFetcherTest. Also an AqlItemBlockInputRange can now ha…

b91be5f

…ndle ShadowRows properly

mchacki added 5 commits March 20, 2020 09:28

Merge branch 'devel' of ssh://github.com/arangodb/ArangoDB into featu…

53d634e

…re/AqlSubqueryExecutionBlockImplExecuteImplementation-batchSubQueries

Made MultiInputRange ready for RangeTest. Test is red still. Also avo…

ece5b7a

…id continous fetching if the client does not do a continuous fetching

ShadowRows in MultiRange is the Maximum, not a Sum.

dc0eb91

Initialize all the dependencies

b2e165c

Merge branch 'devel' of ssh://github.com/arangodb/ArangoDB into featu…

a8638dd

…re/AqlSubqueryExecutionBlockImplExecuteImplementation-batchSubQueries

mchacki requested a review from markuspf March 20, 2020 15:24

mchacki self-assigned this Mar 20, 2020

mchacki added this to the devel milestone Mar 20, 2020

mchacki added 3 commits March 23, 2020 08:09

Add unused flag, because it is not used in one constexpr, but all the…

c960f53

… others...

Merge branch 'devel' of ssh://github.com/arangodb/ArangoDB into featu…

0089e8f

…re/AqlSubqueryExecutionBlockImplExecuteImplementation-batchSubQueries

Fixed compile issue

10a282d

markuspf suggested changes Mar 24, 2020

View reviewed changes

mchacki and others added 8 commits March 24, 2020 16:36

Merge branch 'devel' of ssh://github.com/arangodb/ArangoDB into featu…

3ed641c

…re/AqlSubqueryExecutionBlockImplExecuteImplementation-batchSubQueries

Apply suggestions from code review

998575a

Thank you for spotting and correcting my bad English typing skills Co-Authored-By: Markus Pfeiffer <markuspf@users.noreply.github.com>

Added comments to AqlCallList and AqlCallStack to explain their diffe…

ec2b645

…rence more clearly, thanks for finding this in review

Memorized -> Memoized

d9905c0

Explained the countShadowRows for MultiRanges

589a109

Added clarification comment

620f108

Do not try to write an if, that's impossible. Instead, only try to re…

b1622db

…alize the truth... there is no if.

Added a comment why expectedNumbrOfRows is actually correct

9a4610d

markuspf approved these changes Mar 25, 2020

View reviewed changes

mchacki and others added 2 commits March 25, 2020 10:06

Apply suggestions from code review

4ca7f54

Thanks again for fixing my typos Co-Authored-By: Markus Pfeiffer <markuspf@users.noreply.github.com>

Update arangod/Aql/ExecutionBlockImpl.cpp

0b6e1f1

Co-Authored-By: Markus Pfeiffer <markuspf@users.noreply.github.com>

mchacki merged commit 096dd9b into devel Mar 25, 2020

mchacki deleted the feature/AqlSubqueryExecutionBlockImplExecuteImplementation-batchSubQueries branch March 25, 2020 09:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/aql subquery execution block impl execute implementation batch sub queries #11318

Feature/aql subquery execution block impl execute implementation batch sub queries #11318

mchacki commented Mar 20, 2020

mchacki commented Mar 23, 2020

markuspf left a comment

mchacki commented Mar 24, 2020

markuspf left a comment

Feature/aql subquery execution block impl execute implementation batch sub queries #11318

Feature/aql subquery execution block impl execute implementation batch sub queries #11318

Conversation

mchacki commented Mar 20, 2020

Pull Request Guidelines

Acceptance Checklist

Scope & Purpose

Testing & Verification

Jenkins

mchacki commented Mar 23, 2020

markuspf left a comment

Choose a reason for hiding this comment

mchacki commented Mar 24, 2020

markuspf left a comment

Choose a reason for hiding this comment