Traversal Bugfix #11310
Merged
Traversal Bugfix #11310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goedderz
reviewed
Mar 19, 2020
arangod/Aql/TraversalExecutor.cpp
Outdated
| @@ -226,7 +232,6 @@ auto TraversalExecutor::produceRows(AqlItemBlockInputRange& input, OutputAqlItem | |||
|
|
|||
| while (true) { | |||
| if (_traverser.hasMore()) { | |||
| TRI_ASSERT(_inputRow.isInitialized()); | |||
There was a problem hiding this comment.
Shouldn't that assertion hold again, now that the traverser is reset properly? I'm thinking we need to have an input row before we can start traversing on anything.
There was a problem hiding this comment.
well I deleted this one, because doOutput has the same assertion as well; maybe I just put it back in there, too. It's not as if it costs anything
There was a problem hiding this comment.
I sometimes like such "unnecessary" assertions to document invariants to the reader.
added 2 commits
March 19, 2020 13:50
|
Jenkins now blue. |
jsteemann
reviewed
Mar 19, 2020
All good. |
jsteemann
approved these changes
Mar 19, 2020
|
Tests blue. |
ObiWahn
added a commit
that referenced
this pull request
Mar 25, 2020
…telisting * origin/devel: (80 commits) Feature/aql subquery execution block impl execute implementation batch sub queries (#11318) Fix isAdminUser. (#11326) Bug fix/fixes 20200318 (#11319) updated CHANGELOG Feature/out of search in range (#11324) fix "fix" for collection figures (#11323) updated CHANGELOG compilation fixes for clang-10s more strict checking (#11316) fix failing query (#11317) KShortestPathsExecutor must reset its KShortestPathFinder, including all caches. (#11312) Feature/aql subquery execution block impl execute implementation expected number of rows (#11274) Add DTRACE points to measure request timings. (#11245) USE_STRICT_OPENSSL is Off by default Fix usesRevisionAsDocumentId population and add syncByRevision flag (#11314) Traversal Bugfix (#11310) Bug fix/issue 11275 (#11299) added simple test (#11301) Fix some typos (#10173) Documentation/typos 2020-01-24 (#10975) Update CHANGELOG ...
ObiWahn
added a commit
that referenced
this pull request
Mar 27, 2020
…ql-functions * origin/devel: (25 commits) Bug fix/fixes 20200318 (#11319) updated CHANGELOG Feature/out of search in range (#11324) fix "fix" for collection figures (#11323) updated CHANGELOG compilation fixes for clang-10s more strict checking (#11316) fix failing query (#11317) KShortestPathsExecutor must reset its KShortestPathFinder, including all caches. (#11312) Feature/aql subquery execution block impl execute implementation expected number of rows (#11274) Add DTRACE points to measure request timings. (#11245) USE_STRICT_OPENSSL is Off by default Fix usesRevisionAsDocumentId population and add syncByRevision flag (#11314) Traversal Bugfix (#11310) Bug fix/issue 11275 (#11299) added simple test (#11301) Fix some typos (#10173) Documentation/typos 2020-01-24 (#10975) Update CHANGELOG Some cleanup for new executor test code, which accidentally fixes ASAN failures in ExecutorTestHelper (#11283) LZ4 update (#11306) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing subqueries the
TraversalExecutoris reconstructed in place, which left the traverser, which is contained in theTraversalExecutorInfosin an undefined state. This patch resets the traverser on construction.As a side effect the
PathEnumeratoris also fixed, which did not reset its_activeCursorsvariable correctly.Scope & Purpose
(Can you describe what functional change your PR is trying to effect?)
This PR adds tests that were used to verify all changes: