Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make arangobench return a proper error message #11182

Merged
merged 1 commit into from
Feb 28, 2020
Merged

make arangobench return a proper error message #11182

merged 1 commit into from
Feb 28, 2020

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Make arangobench return a proper error message in case its initial collection creation attempt fails.

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

Testing & Verification

This change is a trivial rework / code cleanup without any test coverage.

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/8774/

@jsteemann jsteemann added this to the devel milestone Feb 27, 2020
@jsteemann jsteemann requested review from xyll and dothebart February 27, 2020 14:59
xyll
xyll reviewed Feb 27, 2020
View reviewed changes
Copy link

@xyll xyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xyll
xyll approved these changes Feb 27, 2020
View reviewed changes
Copy link

@xyll xyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsteemann jsteemann merged commit 0449124 into devel Feb 28, 2020
@jsteemann jsteemann deleted the bug-fix/make-arangobench-return-errors branch February 28, 2020 06:48
ObiWahn added a commit that referenced this pull request Feb 28, 2020
@ObiWahn
Merge remote-tracking branch 'origin/devel' into feature/validation-p…
969959e 
…hase-3

* origin/devel:
  make arangobench return a proper error message (#11182)
  Feature/aql performance improvements (#11160)
KVS85 pushed a commit that referenced this pull request Mar 12, 2020
@jsteemann @KVS85
make arangobench return a proper error message (#11182)
1ff1389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dothebart dothebart dothebart approved these changes

@xyll xyll xyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @xyll @dothebart