simplify options tagging #10974
Merged
simplify options tagging #10974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dothebart
reviewed
Jan 24, 2020
| // OS support | ||
| builder.add("os", VPackValue(VPackValueType::Array)); | ||
| if (option.hasFlag(arangodb::options::Flags::OsLinux)) { | ||
| builder.add(VPackValue("linux")); |
dothebart
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Allow more tags in program options.
Program options can now be annotated with the list of OSes they are supported on, plus the list of arangod components (coordinator, dbserver, agent, single server).
Enterprise companion PR: https://github.com/arangodb/enterprise/pull/384
The extra information can be picked up by our documentation generation process.
Due to the size of the changes, we will not backport this to 3.6 or earlier versions.
Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/8255/