Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use TRI_read_t where appropriate #10935

Merged
merged 12 commits into from
Feb 10, 2020
Merged

use TRI_read_t where appropriate #10935

merged 12 commits into from
Feb 10, 2020

Conversation

dothebart
Copy link
Contributor

No description provided.

@dothebart dothebart requested a review from jsteemann January 20, 2020 16:56
@dothebart
Copy link
Contributor Author

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/8148/

@dothebart
Copy link
Contributor Author

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/8166/

@jsteemann jsteemann added this to the devel milestone Jan 23, 2020
jsteemann
jsteemann reviewed Jan 23, 2020
View reviewed changes
lib/Basics/FileUtils.cpp Outdated Show resolved Hide resolved
@dothebart
Copy link
Contributor Author

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/8421/

jsteemann
jsteemann suggested changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, there is no PR to make the change in the enterprise repository. This is inconsistent, because in enterprise we also use TRI_read_t and TRI_READ and hard-code the result type currently.

CMakeLists.txt Show resolved Hide resolved
lib/Basics/tri-zip.cpp Outdated Show resolved Hide resolved
lib/Basics/tri-zip.cpp Outdated Show resolved Hide resolved
lib/SimpleHttpClient/ClientConnection.cpp Outdated Show resolved Hide resolved
lib/V8/v8-shell.cpp Outdated Show resolved Hide resolved
arangosh/Utils/ManagedDirectory.cpp Outdated Show resolved Hide resolved
dothebart and others added 5 commits February 4, 2020 11:30
@dothebart
fix casts for windows
8a6fd12
@dothebart @jsteemann
Update lib/SimpleHttpClient/ClientConnection.cpp
b3ccd36 
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update lib/V8/v8-shell.cpp
9bc60c4 
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
@dothebart
change name
a2f447d
@dothebart
fix type
1ab4bb2
jsteemann
jsteemann reviewed Feb 10, 2020
View reviewed changes
lib/Basics/tri-zip.cpp Outdated Show resolved Hide resolved
@jsteemann
Copy link
Contributor

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/8440/

@dothebart @jsteemann
Update lib/Basics/tri-zip.cpp
d8aaa7a 
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
@jsteemann jsteemann merged commit 8c91a8d into devel Feb 10, 2020
@jsteemann jsteemann deleted the bug-fix/fix-type-usage branch February 10, 2020 10:00
KVS85 pushed a commit that referenced this pull request Feb 10, 2020
@dothebart
Bug fix/fix msvc2019 build 2 (#11058)
0c12dd6 
* use TRI_read_t where appropriate (#10935)

* re-enable memory settings for MSVS 2019

* re-enable memory settings for MSVS 2019
ObiWahn added a commit that referenced this pull request Feb 11, 2020
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
d414f04 
…ture/validation

* 'devel' of https://github.com/arangodb/arangodb:
  remove unsafe test assertion
  use TRI_read_t where appropriate (#10935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteemann jsteemann jsteemann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
2 participants
@dothebart @jsteemann