-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(redhat): support affected CPE list in OVAL v2 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
force-pushed
the
feat/add_content_sets
branch
from
January 14, 2021 07:04
d7200cc
to
6e44d76
Compare
knqyf263
force-pushed
the
feat/add_content_sets
branch
from
January 18, 2021 08:48
6eed521
to
6c2a631
Compare
knqyf263
force-pushed
the
feat/add_content_sets
branch
from
January 18, 2021 08:51
6c2a631
to
30afff5
Compare
knqyf263
force-pushed
the
feat/add_content_sets
branch
from
January 19, 2021 09:19
4da3f51
to
ad8d906
Compare
masahiro331
reviewed
Feb 23, 2021
|
||
// CentOS has no CPE information in a container image. | ||
if len(cpes) == 0 && adv.FixedVersion != "0" { | ||
advisories = append(advisories, types.Advisory{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my preference:
In this case, it is easier to read using early return.
4 tasks
tonaim
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Red Hat OVAL v2 has affected CPE list and they need to be stored in trivy-db.
Blockers