Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redhat): support affected CPE list in OVAL v2 #101

Merged
merged 39 commits into from
Jan 28, 2022

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Jan 14, 2021

Description

Red Hat OVAL v2 has affected CPE list and they need to be stored in trivy-db.

Blockers

@knqyf263 knqyf263 self-assigned this Jan 14, 2021
@knqyf263 knqyf263 force-pushed the feat/add_content_sets branch from d7200cc to 6e44d76 Compare January 14, 2021 07:04
@knqyf263 knqyf263 force-pushed the feat/add_content_sets branch from 6eed521 to 6c2a631 Compare January 18, 2021 08:48
@knqyf263 knqyf263 force-pushed the feat/add_content_sets branch from 6c2a631 to 30afff5 Compare January 18, 2021 08:51
@knqyf263 knqyf263 marked this pull request as ready for review January 18, 2021 08:58
@knqyf263 knqyf263 requested a review from masahiro331 January 18, 2021 08:58
@knqyf263 knqyf263 force-pushed the feat/add_content_sets branch from 4da3f51 to ad8d906 Compare January 19, 2021 09:19

// CentOS has no CPE information in a container image.
if len(cpes) == 0 && adv.FixedVersion != "0" {
advisories = append(advisories, types.Advisory{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my preference:
In this case, it is easier to read using early return.

@knqyf263 knqyf263 merged commit 5c53ef8 into main Jan 28, 2022
@knqyf263 knqyf263 deleted the feat/add_content_sets branch January 28, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants