Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(misconf): Clean up iac logger #6642

Merged
merged 2 commits into from
May 8, 2024
Merged

chore(misconf): Clean up iac logger #6642

merged 2 commits into from
May 8, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented May 7, 2024

Description

Removes some unnecessary code.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 self-assigned this May 7, 2024
@simar7 simar7 marked this pull request as ready for review May 7, 2024 05:27
@simar7 simar7 requested a review from nikpivkin as a code owner May 7, 2024 05:27
@nikpivkin
Copy link
Contributor

The cgo_enabled.go and cgo_disabled.go files can be deleted.

nikpivkin
nikpivkin approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simar7 simar7 added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit fe5d40e May 8, 2024
12 checks passed
@simar7 simar7 deleted the remove-unneeded-log-funcs branch May 8, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin approved these changes

Assignees

@simar7 simar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simar7 @nikpivkin