-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secret): added support of Docker registry credentials #5720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @sourav977
Thanks for your work!
Left 2 comments. Take a look, please.
@DmitriyLewen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sourav977
Hm...
Looks like I forgot to save second comment about secret group, or GitHub deleted it.
Anyway, could you take a look at 1 more comment please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work @sourav977
@knqyf263 i approved this PR. Take a look, when you have time, please.
Issue: #5669
Description
added support of Docker registry credentials
Related issues
Checklist