fix: replace containers/image with google/go-containerregistry #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
force-pushed
the
go_containerregistry
branch
from
57776e0 to
ebd9e93
Compare
simar7
reviewed
Apr 9, 2020
| @@ -366,7 +366,7 @@ type Vulnerability struct { | |||
| Description string `protobuf:"bytes,6,opt,name=description,proto3" json:"description,omitempty"` | |||
| Severity Severity `protobuf:"varint,7,opt,name=severity,proto3,enum=trivy.common.Severity" json:"severity,omitempty"` | |||
| References []string `protobuf:"bytes,8,rep,name=references,proto3" json:"references,omitempty"` | |||
| LayerId string `protobuf:"bytes,9,opt,name=layer_id,json=layerId,proto3" json:"layer_id,omitempty"` | |||
| Layer *Layer `protobuf:"bytes,10,opt,name=layer,proto3" json:"layer,omitempty"` | |||
There was a problem hiding this comment.
I'm just curious: Why is this by reference? Are custom types always passed by reference?
There was a problem hiding this comment.
I'm not sure, but other custom types are also references.
Line 32 in 1b112c3
simar7
reviewed
Apr 9, 2020
| @@ -102,8 +102,7 @@ func (s *Scanner) Detect(osVer string, pkgs []ftypes.Package) ([]types.DetectedV | |||
| VulnerabilityID: adv.VulnerabilityID, | |||
| PkgName: pkg.Name, | |||
| InstalledVersion: installed, | |||
| //FixedVersion: adv.FixedVersion, // TODO: Why is this missing? | |||
There was a problem hiding this comment.
Would you know why is this missing?
There was a problem hiding this comment.
This is because this bucket stores only unfixed vulnerabilities. I added comments. 49d98c0
GuaoGuao
pushed a commit
to GuaoGuao/trivy
that referenced
this pull request
Jun 24, 2020
…ecurity#456) * chore(mod): update dependencies * fix(internal): remove cleanup * fix: use only diff_id * fix: use string instead of digest * fix: replace LayerID with Layer * test(integration): negotiate API version * feat(conf): add TRIVY_NONSSL * test(integration): update golden files * test(integration): fix the error message * chore(debian): add comments * chore(mod): update dependencies
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
* chore(mod): update dependencies * fix(internal): remove cleanup * fix: use only diff_id * fix: use string instead of digest * fix: replace LayerID with Layer * test(integration): negotiate API version * feat(conf): add TRIVY_NONSSL * test(integration): update golden files * test(integration): fix the error message * chore(debian): add comments * chore(mod): update dependencies
josedonizetti
pushed a commit
to josedonizetti/trivy
that referenced
this pull request
Jun 24, 2022
…security#456) Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. aquasecurity/fanal#96