docker_engine_test: Add more OSes #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #356 Signed-off-by: Simarpreet Singh <simar@linux.com>
|
Would you add all OSes which the following tests? Also, we need to watch the test time since CircleCI has a limitation of 200 minutes. |
|
I can but I feel it will make the test longer than we'd like it to be, so I added one of each kind. Currently it took about ~4 minutes on my machine to run them all. Is the CircleCI limit per month or per week? Have a link to it? |
|
Yes, I agree. It might be better to do other integration tests on GitHub Actions. Here is the link. It is not 200 min, but 250 min per week.
|
Signed-off-by: Simarpreet Singh <simar@linux.com>
knqyf263
approved these changes
Jan 10, 2020
GuaoGuao
pushed a commit
to GuaoGuao/trivy
that referenced
this pull request
Jun 24, 2020
* docker_engine_test: Add more OSes Fixes: aquasecurity#356 Signed-off-by: Simarpreet Singh <simar@linux.com> * integration: Add all OSes for docker mode. Signed-off-by: Simarpreet Singh <simar@linux.com>
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
* docker_engine_test: Add more OSes Fixes: #356 Signed-off-by: Simarpreet Singh <simar@linux.com> * integration: Add all OSes for docker mode. Signed-off-by: Simarpreet Singh <simar@linux.com>
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #356
Signed-off-by: Simarpreet Singh simar@linux.com