Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(asff): replace slice with substr #1058

Merged
merged 1 commit into from
Jun 10, 2021
Merged

fix(asff): replace slice with substr #1058

merged 1 commit into from
Jun 10, 2021

Conversation

knqyf263
Copy link
Collaborator

Masterminds/sprig breaks compatibility. The builtin slice accepts string, while slice from sprig doesn't allow it.
Masterminds/sprig#306

$ AWS_REGION=us-west-1 AWS_ACCOUNT_ID=123456789012 ./trivy image --format template --template "@contrib/asff.tpl" -o report.asff knqyf263/vuln-image
...
2021-06-10T11:42:17.722+0300    FATAL   unable to write results: failed to write results: failed to write with template: template: output template:17:24: executing "output template" at <slice $description 0 1021>: error calling slice: list should be type of slice or array but string

@knqyf263 knqyf263 self-assigned this Jun 10, 2021
@knqyf263 knqyf263 requested a review from masahiro331 June 10, 2021 09:18
@knqyf263 knqyf263 merged commit 2a08969 into main Jun 10, 2021
@knqyf263 knqyf263 deleted the fix_asff branch June 10, 2021 13:19
liamg pushed a commit that referenced this pull request Jun 7, 2022
@knqyf263
fix(asff): replace slice with substr (#1058)
107ee92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahiro331 masahiro331 masahiro331 approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knqyf263 @masahiro331